Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate single plugin returns true even though plugin hasn't been activated #784

Open
hogash opened this issue Sep 9, 2019 · 0 comments

Comments

@hogash
Copy link

hogash commented Sep 9, 2019

Hey guys, i noticed in the activate_single_plugin function if a plugin requires update, this function will still return true even if the plugin hasn't been activated.

Shouldn't this function return false if the plugin hasn't been activated, due to any reason? I would suggest return false in the $this->does_plugin_require_update( $slug ) condition check.

@hogash hogash changed the title Activate Activate single plugin returns true even though plugin hasn't been activated Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant