Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App update when Activity/Triggers are updated #241

Open
ayh20 opened this issue Mar 27, 2018 · 1 comment
Open

App update when Activity/Triggers are updated #241

ayh20 opened this issue Mar 27, 2018 · 1 comment

Comments

@ayh20
Copy link

ayh20 commented Mar 27, 2018

I'm submitting a ... (check one with "x")

[X] bug report 
[X] feature request
[] support request
[] general question

Current behavior (how does the issue manifest):
The "Build" process should be able to pickup the latest version of the components (activity or trigger) in github. A component uninstall/install doesn't result in an update because the metadata is linked to the version of the component from when the gopkg.lock was created.

Expected behavior:

The metadata says that we're on the master branch, so it needs a way to pull the latest version from the master for each component used in an app.
maybe something like: flogo ensure -update

Minimal steps to reproduce the problem (not required if feature enhancement):
Create an app .... update a component it uses .... try to update the app using the new version

What is the motivation / use case for changing the behavior?
Ease of use ...

Please tell us about your environment (Operating system, docker version, browser & verison if webui, etc):
All
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown):
0.5.2

Additional information you deem important (e.g. issue happens only occasionally):

@retgits
Copy link
Contributor

retgits commented May 31, 2018

Hi Andy,

Actually the suggestion you had should do exactly what you want it to.

As an example, I have an app where I have no constraints in my Gokpg.toml so my Gopkg.lock reflects that as well. The below snippet is one of the projects

[[projects]]
  name = "github.com/TIBCOSoftware/flogo-contrib"
  packages = [
    "action/flow",
    "action/flow/definition",
    ...
  ]
  revision = "e127eb1b08cfa49f44a4d2e6ebf6a090ff34a1cd"
  version = "v0.5.3"

Running the command flogo ensure is essentially a wrapper around dep ensure, so it will make sure that your project is in sync: that Gopkg.lock satisfies all the imports (see imports.go) in the project, and all the rules in Gopkg.toml, and that vendor/ contains exactly what Gopkg.lock says it should.

When there are updates you can, as you suggested, run the command flogo ensure -update which does exactly the same its dep counterpart (try to update all dependencies).

So running that command with the above snippet would update it to:

[[projects]]
  name = "github.com/TIBCOSoftware/flogo-contrib"
  packages = [
    "action/flow",
    "action/flow/definition",
    ...
  ]
  revision = "6c29a93c8fafbfafdaa42b884cb6eca739a78d9e"
  version = "v0.5.4"

The revision and version have changed and the files on disk have changed accordingly

This should also work for dependencies that have no version number (like the github.com/julienschmidt/httprouter we use).

So it looks like this is supported, but it could be I misunderstood your question...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants