Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO activity returns done := true on error #306

Open
emilienthomas opened this issue Oct 25, 2018 · 0 comments
Open

GPIO activity returns done := true on error #306

emilienthomas opened this issue Oct 25, 2018 · 0 comments

Comments

@emilienthomas
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[] enhancement request
[] feature request
[] support request
[] general question

Current behavior (how does the issue manifest):
When the GPIO activity encounters or creates an error, the Eval function returns done := true, breaking the activity coding best practice:

Activity Eval() should return true only when completed successfully & err should be returned when an error occurs

Expected behavior:
When err is not nil, done must be equal to true

Minimal steps to reproduce the problem (not required if feature enhancement):

What is the motivation / use case for changing the behavior?
Coherent behavior with other activities

Please tell us about your environment (Operating system, docker version, browser & verison if webui, etc):
GPIO activity requires a raspberry

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.5.6, 0.5.7RC1

Additional information you deem important (e.g. issue happens only occasionally):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant