Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blocking I/O from ReactPHP implementation #8550

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Remove blocking I/O from ReactPHP implementation #8550

merged 7 commits into from
Dec 11, 2023

Commits on Nov 16, 2023

  1. [php] Use libuv for ReactPHP 

    LibUv is the most optimised loop implementation for ReactPHP. This
alters the setup to allow us to properly compare things.

Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ac8e3ab View commit details
    Browse the repository at this point in the history

  2. [php] Bump ReactPHP dependencies 

    Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e23e003 View commit details
    Browse the repository at this point in the history

  3. [php] Optimise docker layers 

    This just makes development more efficient as we avoid downloading
composer and all the dependencies when we only want to propagate updates
to the PHP files.

Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ad9b8c8 View commit details
    Browse the repository at this point in the history

  4. [php] Update ReactPHP usage 

    This makes us rely on the automatic execution of the Loop and removes
usage of deprecated classes.

Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    72db1be View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. [php] Handle SIGINT and SIGTERM in ReactPHP 

    Although this isn't a huge deal, it speeds up development as we don't
need to wait docker to trigger SIGKILL.

Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    28aedbd View commit details
    Browse the repository at this point in the history

  2. [php] Use non-blocking I/O for DB communication 

    Just as AMPHP, ReactPHP requires asynchronous implementations for it to
work as expected. When using PDO we will block the process when
establishing the DB connection and sending queries.

This replaces the implementation with a fully async MySQL client, also
cleaning removing unnecessary extensions from the image.

Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    4f128f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Upgrade PHP to v8.3 

    Signed-off-by: Luís Cobucci <[email protected]>
    @lcobucci
    lcobucci committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    a6657b7 View commit details
    Browse the repository at this point in the history