Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server::listener: provide method for catching binding errors #115

Open
Tectu opened this issue Aug 17, 2022 · 0 comments
Open

server::listener: provide method for catching binding errors #115

Tectu opened this issue Aug 17, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tectu
Copy link
Owner

Tectu commented Aug 17, 2022

As of today, malloy::server::listener binds starts to listen in the constructor. If the acceptor could not start listening (for example because the end-point is already in use), there is no way for a consumer to catch this programmatically.

Possible solutions:

  • Throw in the constructor (meh)
  • Move relevant pieces of code from constructor to run() and return boolean.
@Tectu Tectu added enhancement New feature or request good first issue Good for newcomers labels Aug 17, 2022
@Tectu Tectu changed the title server::listener: provide method of catching binding errors server::listener: provide method for catching binding errors Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant