Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load correct localized messages.properties for CheckStyle #290

Open
TimvdLippe opened this issue Apr 4, 2018 · 2 comments
Open

Load correct localized messages.properties for CheckStyle #290

TimvdLippe opened this issue Apr 4, 2018 · 2 comments

Comments

@TimvdLippe
Copy link
Collaborator

Reading through https://github.com/checkstyle/checkstyle/blob/489ce031e818f955a95c10d9f10668cb1b7b4b54/src/main/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessage.java#L367-L377 showed that we actually need to pass in the Locale for the given bundle, to load the correct message. The Locale we should load is the Locale.getDefault().
@Inventitech
Copy link
Contributor

How is this affecting our current plans?

@TimvdLippe
Copy link
Collaborator Author

This is not blocking right now, but an enhancement for later. It mostly requires investigation, as I suspect we already deal with this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Inventitech @TimvdLippe