-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shall we add fuse.dll to repo #99
Comments
considerations:
instead:
|
Hey all,
This approach would free the developers from having to remember checking in the
To tackle this, we could build either
From my current perspective, the benefits of adding the binaries could outweigh the drawbacks, as this has repeatedly been a point of failure in the past while developing. A developer that needs to work with the latest state of the Fuse repository would no longer have to manually check if files in the It's been discussed in another place that there could be the possibility of using the |
Having had a look at the discussed git-hooks approach; it does not seem possible to share hooks automatically within the repository itself and would make it necessary for every developer to set up that build hook (semi-)manually, as the Not being able to automatically share the hooks with the repository does make sense from a security perspective, as sharing a hooks folder would make it possible to silently execute code on the developers machine just with a checkout of the repository, as the hook files are just shell scripts. |
Keep in mind that for each commit you'll get a second commit from the github action. Not sure that's desirable. I'd also argue for the simple A future option would be to reference the Fuse.csproj from within vvvv - that way vvvv would take care of compiling it. However there's still an open issue on our end to fully support this for libraries / VL packages. Currently it would prevent the library from getting pre-compiled and would therefor cause a longer startup. |
Shall we add fuse.dll to repo so that people can directly work with the repo without compiling? Should we use lfs to add it? Please add opinions.
The text was updated successfully, but these errors were encountered: