-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS OdinBook: Link is missing href #28321
Comments
Hello, I am willing to work on this issue. But should I work on this or let a person contribute for their first time? |
@AhmedTheGreatest I'm happy to assign you, but if you'd prefer to leave it open for a less experienced contributor, then that's also fine. Let me.know what you'd like to do. |
Hi, first time contributor here, I want to work on this issue. |
@MaoShizhong Actually you can assign @JeyLson0 as he is a first time contributor. |
All yours @JeyLson0. Let us know if you run into any problems. |
Thanks for the opportunity @AhmedTheGreatest. @MaoShizhong already sent a PR, let me know if there are any issue. |
Checks
Describe your suggestion
In JS OdinBook, there's a link to
socket.io
that's missing the href. That is, the text literally says[socket.io]
. The lesson file should instead have[socket.io](https://socket.io/)
, which will then render on the website as socket.io.Acceptance criteria
Please comment below if you would like to be assigned to work on this issue. Please do not open a PR unless you have been assigned by a maintainer.
[socket.io]
becomes[socket.io](https://socket.io/)
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/nodejs-odin-book
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: