Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS OdinBook: Link is missing href #28321

Closed
2 of 4 tasks
MaoShizhong opened this issue Jul 1, 2024 · 6 comments · Fixed by #28326
Closed
2 of 4 tasks

JS OdinBook: Link is missing href #28321

MaoShizhong opened this issue Jul 1, 2024 · 6 comments · Fixed by #28326
Assignees

Comments

@MaoShizhong
Copy link
Contributor

Checks

Describe your suggestion

In JS OdinBook, there's a link to socket.io that's missing the href. That is, the text literally says [socket.io]. The lesson file should instead have [socket.io](https://socket.io/), which will then render on the website as socket.io.

Acceptance criteria

Please comment below if you would like to be assigned to work on this issue. Please do not open a PR unless you have been assigned by a maintainer.

  • Add socket.io href, so [socket.io] becomes [socket.io](https://socket.io/)

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/nodejs-odin-book

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@MaoShizhong MaoShizhong added Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors Type: Easy Fix Involves a minor fix such as grammar, syntax, etc. labels Jul 1, 2024
@AhmedTheGreatest
Copy link
Contributor

Hello, I am willing to work on this issue. But should I work on this or let a person contribute for their first time?

@MaoShizhong
Copy link
Contributor Author

@AhmedTheGreatest I'm happy to assign you, but if you'd prefer to leave it open for a less experienced contributor, then that's also fine. Let me.know what you'd like to do.

@JeyLson0
Copy link
Contributor

JeyLson0 commented Jul 1, 2024

Hi, first time contributor here, I want to work on this issue.

@AhmedTheGreatest
Copy link
Contributor

@MaoShizhong Actually you can assign @JeyLson0 as he is a first time contributor.

@MaoShizhong
Copy link
Contributor Author

All yours @JeyLson0. Let us know if you run into any problems.

@MaoShizhong MaoShizhong removed Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors Type: Easy Fix Involves a minor fix such as grammar, syntax, etc. labels Jul 1, 2024
@JeyLson0
Copy link
Contributor

JeyLson0 commented Jul 1, 2024

Thanks for the opportunity @AhmedTheGreatest.

@MaoShizhong already sent a PR, let me know if there are any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants