Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XTMF2 User Object minor suggestions #55

Open
BrendanReilly opened this issue Oct 19, 2019 · 0 comments
Open

XTMF2 User Object minor suggestions #55

BrendanReilly opened this issue Oct 19, 2019 · 0 comments
Assignees
@JamesVaughan
Labels
suggestion Minor suggestion or comment
Projects
XTMF2

Comments

@BrendanReilly
Copy link
Collaborator

Currently User objects in XTMF2 only have the "Admin" property (boolean). For future sake, it might be better refactored into a User which contains a set of roles -- even if there is just the one: admin. This pattern also interfaces with the sister project XTMF2.Web .

The other minor comment would be to rename Admin to IsAdmin to reflect that it is a boolean property (minor).
@BrendanReilly BrendanReilly added the suggestion Minor suggestion or comment label Oct 19, 2019
@BrendanReilly BrendanReilly added this to To do in XTMF2 via automation Oct 19, 2019
@JamesVaughan JamesVaughan moved this from To do to In progress in XTMF2 Oct 20, 2019
@JamesVaughan JamesVaughan mentioned this issue Oct 20, 2019
Merged
@JamesVaughan JamesVaughan added this to the Core Prototype 2 milestone Oct 28, 2019
@JamesVaughan JamesVaughan removed this from the Core Prototype 2 milestone Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesVaughan JamesVaughan

Labels
suggestion Minor suggestion or comment
Projects
XTMF2
  
In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesVaughan @BrendanReilly