-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing current git tag with python version 3 #53
Comments
This appears to still be a problem. The commit string in the output files is not correct, both in the tag value or git hash |
Another case for setuptools_scm? |
That's what I was thinking. The important thing though is we're getting the git hash if we're in a repo so we'd want to use the scheme that has the commit hash. |
Merged
Fixed with #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With python 3, the current method for getting the current git tag using subrpocess.check_output returns a byte string. This can be fixed with another option in the command.
The text was updated successfully, but these errors were encountered: