Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing current git tag with python version 3 #53

Closed
micah-prime opened this issue Dec 18, 2017 · 4 comments
Closed

Importing current git tag with python version 3 #53

micah-prime opened this issue Dec 18, 2017 · 4 comments

Comments

@micah-prime
Copy link
Contributor

With python 3, the current method for getting the current git tag using subrpocess.check_output returns a byte string. This can be fixed with another option in the command.

@scotthavens
Copy link
Contributor

This appears to still be a problem. The commit string in the output files is not correct, both in the tag value or git hash

@jomey
Copy link
Collaborator

jomey commented Jun 11, 2020

Another case for setuptools_scm?

@scotthavens
Copy link
Contributor

That's what I was thinking.

The important thing though is we're getting the git hash if we're in a repo so we'd want to use the scheme that has the commit hash.

@scotthavens
Copy link
Contributor

Fixed with #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants