Should swappedInSpace->Contains(object) in line 1036 of function GcRecordFree be !swappedInSpace->Contains(object)?

[dpinthinker]

marvin-art/runtime/marvin_swap.cc

Lines 1019 to 1038 in 2c1c1d7

	void GcRecordFree(Thread * self, mirror::Object * object) {
	if (!swapEnabled) {
	return;
	}
	/*
	* The correctness of this check depends on upon several assumptions:
	* 1) Only the garbage collectors and my swapping code call Free() on the
	* RosAlloc space and large object space.
	* 2) The garbage collectors never run concurrently with any swapping
	* methods that free objects or stubs as part of swapping (currently,
	* the only such method is SwapObjectsOut()).
	*/
	if (creatingStubs) {
	return;
	}
	if (swappedInSpace->Contains(object)) {
	return;
	}

I think it may be missing a ! in front of swappedInSpace->Contains(object) in line 1036

[nlebeck]

My memory's quite hazy, but I think that check might be WAI. If object is a stub, we want to process it in this method, but if object is an object in the swap space pointed to by a stub, we don't want to process it here. (We'll take care of it when processing its stub.)

[dpinthinker]

I may got it. If the object is in SwappedInSpace, it means the object is swaped-in on demand. So don't need to handle it here and should leave it to SwappedInSpace to free it.