Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt merging patches in callback sequencer #851

Open
ddworak opened this issue Aug 27, 2021 · 0 comments
Open

Attempt merging patches in callback sequencer #851

ddworak opened this issue Aug 27, 2021 · 0 comments

Comments

@ddworak
Copy link
Member

ddworak commented Aug 27, 2021

TBH I'm not a fan of both solutions right now. In a test case you've pointed out I'd expect single patch emitted with:

  • 5 elements removed: (1, 2), (3, 4), (7, 8), (9, 10), (13, 14),
  • 4 elements added: (3, 4), (7, 8), (9, 10), (13, 14).

If we can't implement a structure listener this way, I'd prefer previous behaviour (emitting an "intermediate" patch with defaultA value used, and then a "final" one) than current (emitting the "final" patch, and removing/adding the same afterwards). However we should fire a structure listener once IMO if both elements are removed from numbers within a CallbackSequencer.

Originally posted by @bgrochal in #735 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant