Version v2.36.16 removes logs for the --credential-process flag

[seraco]

What

Version v2.36.16 stopped producing logs when the --credential-process flag is passed to the login command. This stops showing the MFA number necessary for logging in.

Points to note:

• We are using the ADFS provider.
• We use MFA in conjunction with saml2aws in credential helper mode.
• We use the MFA mode where the phone app prompts for a two-digit number (the user has to read that two digit number from the saml2aws logs).
• The version v2.36.16 breaks the auth flow for us and maybe for other MFA users?
• If the change is intentional, is there an alternative approach?
• We are happy to raise a PR for any solution we agree on with you.

Why

In the following lines version v2.36.16 added a conditional check to exclude the logs:

    if *quiet || (command == cmdLogin.FullCommand() && loginFlags.CredentialProcess) {
        log.SetOutput(io.Discard)
        logrus.SetOutput(io.Discard)
    }