Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load iframe only when needed #36

Open
sahithyandev opened this issue Jul 9, 2023 · 2 comments
Open

Load iframe only when needed #36

sahithyandev opened this issue Jul 9, 2023 · 2 comments

Comments

@sahithyandev
Copy link
Collaborator

The iframe I am talking about is the sidebar that appears when the extension is activated (by clicking the icon).

Currently, the extension creates and loads an iframe for each tab on load. However the iframe is only shown after the user activates the extension. This causes unwanted resource usage (CPU and RAM) for users.

I suggest we only create the iframe when the extension is activated.
This might cause longer response times to show the iframe. I don't think it will be notable though. Will update if I measure it.

@VenkatTeja
Copy link
Collaborator

@sahithyandev Can explore. Unless u think it will have significant impact on performance, ignore this.
Assume even low end PCs for our users.

@sahithyandev
Copy link
Collaborator Author

I did notice a little performance issue on particular websites while I was using. This is very low in priority though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants