Fix a bug where the dropdown with available dictionary items has only the first item #2725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've run into a rare bug where some of our organization objects did not display full list of available dictionary items for one of the dynamic properties in the management -> Dynamic properties blade. The dropdown had just the first item. This turned out to happen when the API sent a value object with
valueType
ofUndefined
and no actualvalue
property, something like this:We don't know why the value was like that (maybe a side effect of migrating from VC 2), but it caused the following piece of JS to fail:
vc-platform/src/VirtoCommerce.Platform.Web/wwwroot/js/common/directives/genericValueInput.js
Line 103 in a872fba
Specifically, dereferencing
x.value.id
breaks the loop (as there is novalue
property) in its first iteration, hence only one item ends up in the dropdown.