Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using wasi:io/error/error instead of a custom error resource #22

Open
fibonacci1729 opened this issue May 16, 2024 · 2 comments

Comments

@fibonacci1729
Copy link

fibonacci1729 commented May 16, 2024

As a bit of early implementation feedback, i found that implementing the host side of things for wasi:messaging/messaging-types/error imposed a bit of a hurdle/challenge.

How would everyone feel to replace the custom error resource defined in this package with wasi:io/error/error.

Alternatively, to make host-side implementations easier to wrangle, i'd suggest isolating out the error type into its own interface (similar to wasi:ios error) which would minimize the host code required.

Wdyt?

@thomastaylor312
Copy link
Collaborator

I would definitely prefer its own interface if possible in the options you presented, but I am also rather partial to errors being represented as enums rather than opaque resources. Was thinking about changing that as part of an upcoming PR to integrate some feedback from people

@thomastaylor312
Copy link
Collaborator

Heads up @fibonacci1729 that I added error as a variant in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants