From cd24f4d45928bee31f7d2e6d0be3f2627c22210e Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 13 Dec 2022 22:52:09 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../pygments/lexers/_php_builtins.py | 21 ++++++++++++++++++- pgsql/pgAdmin 4/venv/Lib/tarfile.py | 21 ++++++++++++++++++- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/pgsql/pgAdmin 4/venv/Lib/site-packages/pygments/lexers/_php_builtins.py b/pgsql/pgAdmin 4/venv/Lib/site-packages/pygments/lexers/_php_builtins.py index 39a39057..f63ab7cc 100644 --- a/pgsql/pgAdmin 4/venv/Lib/site-packages/pygments/lexers/_php_builtins.py +++ b/pgsql/pgAdmin 4/venv/Lib/site-packages/pygments/lexers/_php_builtins.py @@ -4726,7 +4726,26 @@ def get_php_functions(): def get_php_references(): download = urlretrieve(PHP_MANUAL_URL) with tarfile.open(download[0]) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) for file in glob.glob("%s%s" % (PHP_MANUAL_DIR, PHP_REFERENCE_GLOB)): yield file os.remove(download[0]) diff --git a/pgsql/pgAdmin 4/venv/Lib/tarfile.py b/pgsql/pgAdmin 4/venv/Lib/tarfile.py index edd31e96..465e7467 100644 --- a/pgsql/pgAdmin 4/venv/Lib/tarfile.py +++ b/pgsql/pgAdmin 4/venv/Lib/tarfile.py @@ -2498,7 +2498,26 @@ def main(): if is_tarfile(src): with TarFile.open(src, 'r:*') as tf: - tf.extractall(path=curdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=curdir) if args.verbose: if curdir == '.': msg = '{!r} file is extracted.'.format(src)