Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Button Alignment for Stories #16

Open
aashutoshrathi opened this issue Jan 21, 2018 · 14 comments
Open

Fix Button Alignment for Stories #16

aashutoshrathi opened this issue Jan 21, 2018 · 14 comments

Comments

@aashutoshrathi
Copy link
Owner

Current Look:
bug

@adin234
Copy link
Contributor

adin234 commented Oct 5, 2018

this is my proposed layout, is this fine with you?

image

@aashutoshrathi
Copy link
Owner Author

Go ahead @adin234

@lalitmee
Copy link
Contributor

Hey @aashutoshrathi, if we are confirmed that we can use the design which @adin234 has suggested then I can implement that.

@aashutoshrathi
Copy link
Owner Author

We need to do something like that only, but it's better if we can place it in line with three dots.

@lalitmee
Copy link
Contributor

Yeah that would also be better idea to put in the line and that would also not take up the extra space. 👍

@adin234
Copy link
Contributor

adin234 commented Dec 23, 2018

@lalitmee i think that PR was already merged before

@aashutoshrathi
Copy link
Owner Author

@adin234 Instagram changed the div map for Stories, so it is not working now.

@lalitmee
Copy link
Contributor

Hey @aashutoshrathi, I was looking for the buttons in the stories but for me, there is no button on the stories.

@leventdeniz
Copy link

leventdeniz commented Dec 24, 2018

@lalitmee I have the same issue. I think it has to do with how the content on the page is loaded. The extension does not know when there is new content loaded and therefore doesn't load the buttons.

If you load some stories directly by reloading the story url, the buttons appear (tried this one https://www.instagram.com/stories/alternate.de/). But it doesn't always work, at marvel's story the buttons just won't appear (https://www.instagram.com/stories/marvel/)

And in the case where the buttons do load, they are also displayed correctly as shown further above

@aashutoshrathi
Copy link
Owner Author

@leventdeniz then we have to reload the inject button function each time page changes.

@lalitmee
Copy link
Contributor

@leventdeniz, yeah I think it has something to do loading of the page. But if you notice on the load of instagram we can see the second post's header when we are on the first post.

@aashutoshrathi, yeah we can use any method of Javascript like onscroll for reloading if there is need of that.

@aashutoshrathi
Copy link
Owner Author

@lalitmee I'm already using onscroll

@lalitmee
Copy link
Contributor

Oh, then we have to debug it why its taking so much time for post other than the 1st one. I think there is something in the if and else condition which is looping again and again.

@leventdeniz
Copy link

I tried onload and also tried to listen for url changes but it didn't work for some reason. Didn't had too much time to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants