Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1271: Fix XDG Base Dir implementation #1682

Open
danepowell opened this issue Feb 12, 2024 · 0 comments
Open

CLI-1271: Fix XDG Base Dir implementation #1682

danepowell opened this issue Feb 12, 2024 · 0 comments

Comments

@danepowell
Copy link
Contributor

Our XDG Base Dir implementation isn't quite right. If $HOME/.acquia doesn't exist and $XDG_CONFIG_HOME is unset, ACLI will create the new config directory at $HOME/.config/acquia. But this is very Linux-centric. On MacOS and Windows, there are more appropriate directories (e.g., $HOME/Library/Application Support and LocalAppData).

We should fix this by using an existing XDG Base Dir implementation: https://github.com/php-xdg/base-directory

The problem is if we fix this now, it will break folks who've already adopted the new location on MacOS and Windows. So we need to maintain backwards compatibility with both legacy locations, or else have a major release and BC-break.

@github-actions github-actions bot changed the title Fix XDG Base Dir implementation CLI-1271: Fix XDG Base Dir implementation Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant