Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non unique schedule redis lock key #42

Open
marcowindt opened this issue Jun 18, 2024 · 2 comments
Open

Non unique schedule redis lock key #42

marcowindt opened this issue Jun 18, 2024 · 2 comments

Comments

@marcowindt
Copy link

We ran into the issue that Redis lock key for job scheduler is non-deterministic across nodes when using Jason encode, since the key is based on the MD5 hash of the serialized job. Right now the order of the keys in json object has to be the same which is not always the case, resulting in different keys for the same job.

Using a custom serializer fixes this. We now use Jason encode with ordered keys option.

Leaving a comment in case someone else runs into this in the future.

@ananthakumaran
Copy link
Contributor

Thanks for reporting. If your fix is generic, we can do the same in ExqScheduler itself. I will look into this weekend

@barttenbrinke
Copy link

Ran into this too, this might be a good thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants