Add more options for the background #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome to have the background color of the video transparent. Is this possible? |
|
@godomac mp4 does not support transparent background colors. That would require a different raw video format like AVI or QuickTime (.mov). I suggest opening a feature request, that's way out of scope of this PR. |
adefossez
requested changes
Nov 23, 2023
| @@ -130,17 +147,18 @@ def draw_env(envs, out, fg_colors, bg_color, size): | |||
| pad = pad_ratio * width | |||
| delta = 2 * pad + width | |||
|
|
|||
| ctx.translate(*offset) | |||
There was a problem hiding this comment.
why do you need this offset here ?
| image = image.resize(image.width + 1, image.height) | ||
| if image.height % 2 is 1: | ||
| image = image.resize(image.width, image.height + 1) | ||
| output_size = image.width, image.height |
There was a problem hiding this comment.
I'm not sure we should replace the output size with tjhe image size, maybe we should rather keep the video width and height controlled by the params, and resize the image given as background ? or maybe add a flag --use_background_image_size
Passing image size as tuple & fixing SyntaxWarning on literal identity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more options to specify both the background color as well as an image as the background. Also additionally the ability to set the opacity of the bars.
Options added: