Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abstract Class HasKind and incorporate directly in class Subclass #434

Open
BirgitBoss opened this issue May 27, 2024 · 0 comments
Open
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented May 27, 2024

Is your feature request related to a problem? Please describe.
The only class inherting HasKind is Submodel (in former versions it was also SubmodelElement). Abstract classes are typically only introduced if several classes are inheriting from them.

Describe the solution you'd like
Remove abstract Class HasKind and incorporate directly in class Submodel

The change is backward compatible but changes the schemas implementing the abstract classes as well.

Some constraints are effected like Constraint AASd-119: If any Qualifier/kind value of a Qualifiable/qualifier is equal to 980 TemplateQualifier and the qualified element inherits from "hasKind" then the qualified element 981 shall be of kind Template (HasKind/kind = "Template").

@BirgitBoss BirgitBoss added this to the V3.1 milestone May 27, 2024
@BirgitBoss BirgitBoss added the specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally label May 27, 2024
@BirgitBoss BirgitBoss changed the title Remove abstract Class hasKind and incorporate directly in class Subclass Remove abstract Class HasKind and incorporate directly in class Subclass May 27, 2024
@BirgitBoss BirgitBoss added the requires workstream approval strategic decision in spec team needed label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

1 participant