Improve test coverage through integration tests #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st gets generated
|
This PR will trigger no release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
===========================================
+ Coverage 73.83% 84.58% +10.75%
===========================================
Files 5 5
Lines 493 493
===========================================
+ Hits 364 417 +53
+ Misses 129 76 -53 ☔ View full report in Codecov by Sentry. |
ekremney
reviewed
Jul 4, 2024
| <img src="/test/it/img.test.html"> | ||
| <script type="module"> | ||
| import { runTests } from '@web/test-runner-mocha'; | ||
| import { sendMouse } from '@web/test-runner-commands'; |
There was a problem hiding this comment.
@kptdobe referring to the discussion we had back in rumathon, maybe this sendMouse command what we needed for the INP test?
There was a problem hiding this comment.
The challenge may be that we have to navigate away from the page and that can interfere with recording the test results.
kptdobe
previously approved these changes
Jul 4, 2024
| <img src="/test/it/img.test.html"> | ||
| <script type="module"> | ||
| import { runTests } from '@web/test-runner-mocha'; | ||
| import { sendMouse } from '@web/test-runner-commands'; |
There was a problem hiding this comment.
Suggested change
| import { sendMouse } from '@web/test-runner-commands'; |
There was a problem hiding this comment.
You got me. I'm clicking now.
| <img src="/test/it/img.test.html"> | ||
| <script type="module"> | ||
| import { runTests } from '@web/test-runner-mocha'; | ||
| import { sendMouse } from '@web/test-runner-commands'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a bit more painful than I expected.
The integration test now loads helix-rum-enhancer through
a (slightly prepared) version of helix-rum-js and then
validates the checkpoints that have been sent using a mocked
navigator.sendBeacon. This helps to bring up the coverageof
index.js, but there are still good chunks of it thatrequire more fiddling, especially when we look at URL parameter
comprehension