Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique clients metric is incorrect #57

Open
StephenCoady opened this issue May 30, 2018 · 0 comments
Open

Unique clients metric is incorrect #57

StephenCoady opened this issue May 30, 2018 · 0 comments

Comments

@StephenCoady
Copy link
Contributor

StephenCoady commented May 30, 2018

Expected Behavior

When sending metrics such as security checks, the unique client count should only increase by 1 irrespective of how many times those metrics are sent from that client.

Actual Behavior

Each time a metric is published the unique client count increased by 1. This does not currently happen with app and device metrics - only with custom metrics such as security.

Steps to Reproduce the Problem

The easiest way to reproduce this is using one of the showcase applications. Using the cordova application and the mobile core with metrics running:

  1. Run the device and navigate to the authentication page. The unique client count in displayed in Grafana should increment by 1. If the app is rebuilt and rerun and the authentication page loaded again, the count stays at 1.
  2. Navigate to the Device Trust page. This sends four metrics in a security array, as defined by this api. The count here will only increase by 1.
  3. Re-load the page and the metrics will be re-sent. The unique client count will now increase by 1.

Specifications

  • Metrics API version: 0.0.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant