Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot token is clearly visible #6

Open
brookmg opened this issue Mar 20, 2020 · 1 comment
Open

Bot token is clearly visible #6

brookmg opened this issue Mar 20, 2020 · 1 comment

Comments

@brookmg
Copy link
Member

brookmg commented Mar 20, 2020

  • The bot token is clearly visible in the commits. It would be alright if it's only for development purposes but not the best practice none the less.
  • Possible Fix: There is a PR ( BOT TOKEN removed! #4 ) that can close this. but would still need some commits to be rebased for complete removal.
@theShinigami
Copy link
Collaborator

I have already sent PR, changed it to .env to i'm get waiting for a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brookmg @theShinigami