Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance_tests dir is installed #2469

Closed
hadim opened this issue Jan 10, 2023 · 2 comments
Closed

performance_tests dir is installed #2469

hadim opened this issue Jan 10, 2023 · 2 comments
Labels
area / packaging Isuue area: Improvements in packaging pipelines help wanted Extra attention is needed phase / shipped Issue phase: shipped type / bug Issue type: something isn't working
Milestone
v3.16.0

Comments

@hadim
Copy link

hadim commented Jan 10, 2023

I spotted this while inspecting the content of the conda forge package at conda-forge/aim-feedstock#14

The fix is probably as simple as replacing packages = find_packages(exclude=('tests', 'aim.web.ui')) by packages = find_packages(exclude=('tests', 'performance_tests', 'aim.web.ui')) in the setup.py file.
@hadim hadim added help wanted Extra attention is needed type / bug Issue type: something isn't working labels Jan 10, 2023
@gorarakelyan gorarakelyan added the area / packaging Isuue area: Improvements in packaging pipelines label Jan 10, 2023
@gorarakelyan gorarakelyan added this to the v3.15.x milestone Jan 10, 2023
@gorarakelyan
Copy link
Contributor

@hadim thanks for pointing this out.

@alberttorosyan alberttorosyan added the phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release label Jan 25, 2023
@alberttorosyan
Copy link
Member

The issue has been addressed here: https://github.com/aimhubio/aim/pull/2477/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R199
Merged and shipped with Aim 3.16.0 release

@alberttorosyan alberttorosyan added phase / shipped Issue phase: shipped and removed phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release labels Feb 6, 2023
@alberttorosyan alberttorosyan modified the milestones: v3.15.x, v3.16.0 Feb 6, 2023
@hadim hadim closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area / packaging Isuue area: Improvements in packaging pipelines help wanted Extra attention is needed phase / shipped Issue phase: shipped type / bug Issue type: something isn't working
Projects
Aim roadmap
Status: Done
Milestone
v3.16.0
Development

No branches or pull requests
3 participants
@hadim @gorarakelyan @alberttorosyan