Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of groups #101

Open
diplo7 opened this issue Jul 17, 2021 · 7 comments
Open

Separation of groups #101

diplo7 opened this issue Jul 17, 2021 · 7 comments

Comments

@diplo7
Copy link

diplo7 commented Jul 17, 2021

You might consider creating a button to enable or disable word highlighting for each group. For example: "I want only group "A" to be highlighted on this page, or only group A and group C, but not group B. This helps not to have word clashes in different languages. Another thing would be the possibility to export groups separately.

@ainzzorl
Copy link
Owner

Thanks for proposal.

Something like a per-group setting with a list of pages where the group should not be highlighted? This would be helpful. Related issue: #86

Exporting groups separately - definitely. Let's track it separately - #102

@diplo7
Copy link
Author

diplo7 commented Jul 26, 2021

I study three languages simultaneously and I have noticed that some words are similar to each other, but they have different meanings. Currently, it is only possible to save one word and only one description for it. However, would it be possible to repeat the words between groups? I mean, never repeat a word within a group, but it can be repeated between groups. For example: word "suit" has a description in the "English" group, it cannot be repeated within this group, but it can also be saved in the "French" group as well, but with another description and highlighter color. This would make sense along with the next update (turning off or turning on groups separately on sites).

@ainzzorl
Copy link
Owner

Thanks for the suggestion. It seems a useful feature. But of course it would only make sense once groups can be turned on and off on different sites. I'm not sure how soon I can add it.

@ainzzorl
Copy link
Owner

You can now disable highlighting on certain pages, for all words or for specific groups. See "Don't highlight on these pages" and "Except on these pages" under "Settings" and "Groups" tabs.

E.g. to disable a specific group on example.com set "Don't highlight on these pages" to "example.com". To disable a group on all pages except example.com, set "Don't highlight on these pages" to "*" and "Except on these page" to "example.com".

@diplo7
Copy link
Author

diplo7 commented Aug 23, 2021

Great! But I have found a little problem here. When I disable " www.youtube.com ", the whole site is disabled even when I want to able a specific page on the Youtube. For instance: "Don't highlight on these pages: " www.youtube.com ", "Except on these page: www.youtube.com/watch?v=wIQLL0x6lPQ". However, both the pages are disabled.

@ainzzorl
Copy link
Owner

ainzzorl commented Aug 23, 2021

Thanks a lot for reporting the issue!

There's a bug in how in handles question marks in the URLs. For the time being, you an bypass it by replacing "www.youtube.com/watch?v=wIQLL0x6lPQ" with "www.youtube.com/watch\?v=wIQLL0x6lPQ" (notice the back slash before the question mark).

Tracking the bug here: #116.

@ainzzorl
Copy link
Owner

Fixed the bug. Your settings should work once you receive the 1.7.2 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants