Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PitchClass should allow working with IntervalClass in transposeBy, interval methods #248

Open
albertms10 opened this issue Aug 5, 2023 · 0 comments
Assignees
Labels
help wanted Extra attention is needed refactor The code needs to be refactored

Comments

@albertms10
Copy link
Owner

albertms10 commented Aug 5, 2023

// TODO(albertms10): expect [IntervalClass]. See #248.
PitchClass transposeBy(Interval interval) =>
PitchClass(semitones + interval.semitones);

// TODO(albertms10): return [IntervalClass]. See #248.
Interval interval(PitchClass other) {
final diff = difference(other);

@albertms10 albertms10 added help wanted Extra attention is needed refactor The code needs to be refactored labels Aug 5, 2023
@albertms10 albertms10 added this to the Road to 0.12 milestone Aug 5, 2023
@albertms10 albertms10 self-assigned this Aug 5, 2023
@albertms10 albertms10 modified the milestones: Road to 0.12, Road to 0.13 Sep 1, 2023
@albertms10 albertms10 removed this from the Road to 0.13 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactor The code needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant