Moved playwright test navigation to RendererFixture

alexandercerutti · Feb 15, 2024 · 8190924 · 8190924
1 parent 2b04f50
commit 8190924
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/captions-renderer/specs/RendererFixture.ts b/packages/captions-renderer/specs/RendererFixture.ts
@@ -8,7 +8,13 @@ interface RendererFixture {
 	waitForEvent(event: "playing"): Promise<void>;
 }
 
+const SUB37_SAMPLE_PAGE_PATH = "./pages/sub37-example/index.html";
+
 export const RendererFixture = base.extend<RendererFixture>({
+	page({ page }, use) {
+		page.goto(SUB37_SAMPLE_PAGE_PATH);
+		return use(page);
+	},
 	getFakeVideo({ page }, use) {
 		return use(() => page.locator("fake-video"));
 	},

diff --git a/packages/captions-renderer/specs/renderer.spec.pw.ts b/packages/captions-renderer/specs/renderer.spec.pw.ts
@@ -1,8 +1,6 @@
 import { expect } from "@playwright/test";
 import { RendererFixture as test } from "./RendererFixture.js";
 
-const SUB37_SAMPLE_PAGE_PATH = "./pages/sub37-example/index.html";
-
 test("Renderer should render two regions if the tracks owns two regions", async ({
 	page,
 	waitForEvent,
@@ -35,8 +33,6 @@ scroll:up
 <v Bill>Hi, I’m Bill
 `;
 
-	await page.goto(SUB37_SAMPLE_PAGE_PATH);
-
 	await Promise.all([
 		waitForEvent("playing"),
 		page.getByRole("textbox", { name: "WEBVTT..." }).fill(TEST_WEBVTT_TRACK),
@@ -72,8 +68,6 @@ scroll:up
 <v Bill>Hi, I’m Bill
 `;
 
-	await page.goto(SUB37_SAMPLE_PAGE_PATH);
-
 	await Promise.all([
 		waitForEvent("playing"),
 		page.getByRole("textbox", { name: "WEBVTT..." }).fill(TEST_WEBVTT_TRACK),
@@ -123,8 +117,6 @@ STYLE
 <v Bill>Hi, I’m Bill
 `;
 
-	await page.goto(SUB37_SAMPLE_PAGE_PATH);
-
 	await Promise.all([
 		waitForEvent("playing"),
 		page.getByRole("textbox", { name: "WEBVTT..." }).fill(TEST_WEBVTT_TRACK),