add into_vec #652
Open
add into_vec #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea is to use let mut bytes: Vec<u8> = Vec::with_capacity(len);
resp.into_reader()
.read_to_end(&mut bytes)?;If that's unclear, we could look into making the doc better. |
|
Isn't this the same code that I sent? This PR exists because it's pretty common to want the into_reader to actually be a |
| @@ -481,6 +481,17 @@ impl Response { | |||
| } | |||
| } | |||
|
|
|||
| pub fn into_vec(self) -> Result<Vec<u8>, Error> { | |||
| let size = self | |||
| .header("Content-Type") | |||
There was a problem hiding this comment.
Is this supposed to be "Content-Length"?
Also, what happens if e.g. "Transfer-Encoding: chunked" is used?
Using into_reader seems more convenient.
There was a problem hiding this comment.
Is this supposed to be "Content-Length"?
Oops it is :)
Also, what happens if e.g. "Transfer-Encoding: chunked" is used?
Well in that case more allocations will be made, this is just a small optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some work to do but this would be the general idea