Add HTTPS proxy support #719
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of HTTPS proxy support requires a change of the `connect_host` interface. The return type is changed, but since this is only used internally in this one file and has visibility pub(crate) this should not be a breaking change.
|
force pushed to fix clippy lints |
This was referenced Feb 12, 2024
DanGould
added a commit
to payjoin/rust-payjoin
that referenced
this pull request
Mar 17, 2024
Previously we were supplying the OHTTP Gateway's Key Configuration `OhttpKeys` manually with configuration. Now that the Rust ohttp-relay supports fetching it via https-in-https CONNECT tunnel, we can fetch it from the server while revealing our IP address only to an ohttp relay. While ureq and reqwest advertise https-in-https CONNECT functionality, in practice neither properly tunnels TLS in TLS, though I'm [trying to change this](algesten/ureq#719). For this reason this version uses https-in-http CONNECT which still gets an authenticated response from the gateway (payjoin directory) Now we only e2e test v1 payjoin cli, and this is complex behavior we probably want to test for which means standing up an ohttp-relay, payjoin directory, and provisioning https certs for them in testing. ## Regarding Configuration This PR makes it possible to provide an optional default ohttp-keys config to override fetching one. In the future, ohttp-keys may be cached per-directory and only refreshed when they fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS tends to be the default these days, and I would like to proxy via some server that are HTTPS only using ureq.
I ran into a small issue where we're calling
Response::do_from_streamwhich takes ownership of thetls_streamthat we ultimately need to return, and there's no easy way to clone aBox<dyn ReadWrite>returned fromtls_conf.connect(..), but it seems surmountable. The old PR didn't have this problem because I theStreamabstraction wasn't being used inconnect_host. Any suggestion to address this problem?This reopens #544