Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyclean v3 features #12

Closed
bittner opened this issue May 27, 2024 · 1 comment · Fixed by #15
Closed

Use pyclean v3 features #12

bittner opened this issue May 27, 2024 · 1 comment · Fixed by #15
Assignees
Labels
enhancement New feature or request

Comments

@bittner
Copy link

bittner commented May 27, 2024

I saw you use pyclean in your Makefile.

Note that you can now simplify that code, leveraging modern pyclean features:

--- a/Makefile
+++ b/Makefile

 clean:
-	pyclean .
-	rm -rf .pdb/ obsolete/ .mypy_cache/ .pytest_cache/ .ruff_cache/ htmlcov/ .coverage
+	pyclean . --debris --erase .pdb/**/* .pdb/ obsolete/**/* obsolete/

The --debris option will take care of all commonly known build files and folders. With --erase you can clean up arbitrary files.

Note: Add a --yes to the end of the line if you're sure the --erase works as you expected. Try with --verbose --dry-run first, maybe.

If you think .pdb should also be a --debris target feel free to open an issue or submit a PR on the pyclean repository.

Thanks for using PyClean! 🍰

Reference

@alxdrcirilo alxdrcirilo self-assigned this Jul 14, 2024
@alxdrcirilo alxdrcirilo added the enhancement New feature or request label Jul 14, 2024
@alxdrcirilo
Copy link
Owner

Hi @bittner 👋

Love PyClean!
Thank you for taking the time to recommend the changes! I will edit the Makefile to reflect them.

@alxdrcirilo alxdrcirilo linked a pull request Jul 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants