Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The functions you are calling could change at any time #1

Open
w0rp opened this issue Jan 21, 2019 · 2 comments
Open

The functions you are calling could change at any time #1

w0rp opened this issue Jan 21, 2019 · 2 comments

Comments

@w0rp
Copy link

w0rp commented Jan 21, 2019

I had a look through the functions you're calling, and there are quite a few functions in the ALE codebase that are not part of the public API. You can call them, but changes in ALE could break your code at any time.

Eventually ALE will offer a public API for completion sources. See here: dense-analysis/ale#2143

@andreypopp
Copy link
Owner

@w0rp thanks for reviewing this!

Yeah, definitely this is a dirty hack and I understand that it can break anytime but this haas unblocked me in the meantime for my migration to LSP-based linters/completions/....

dense-analysis/ale#2143 looks great and I wanted to propose to expose other LSP method in ALE. I think ALE is a great cornerstone experience for LSP — it syncs docs and lints but UI for other features are too opinionated sometimes and thus I'd prefer to be able to add my own plugins (like asyncomplete here).

@w0rp
Copy link
Author

w0rp commented Jan 21, 2019

Yeah, that's the intention. With a few changes, people can integrate the LSP message part with other completion plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants