Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Suggest changing the UI layer injection method of Analytics Instance in Analytics Module. #1471

Open
2 tasks done
rhkrwngud445 opened this issue May 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rhkrwngud445
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

Suggest changing the UI layer injection method of Analytics Instance in Analytics Module.

Instead of using CompositionLocal, how about using Hilt's EntryPoint?

It has these advantages.

  1. It has the advantage of reducing MainActivity injection code.
  2. Management outside HiltScope can be reduced.
  3. Analytics can eliminate compose dependency.

Additionally, in analytics/AnalyticsModule, how about creating an instance as a singleton?

Describe the solution

Change Injection of CompositionLocal to Hilt's EntryPoint

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Pandabar007
Copy link

Get newer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants