Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: $updateCommands #602

Open
1 task done
valentineu0 opened this issue May 26, 2024 · 6 comments
Open
1 task done

Bug: $updateCommands #602

valentineu0 opened this issue May 26, 2024 · 6 comments
Assignees
Labels
Issue:Needs Reproduction needs reproduction Type:Bug Something causing unexpected behaviour

Comments

@valentineu0
Copy link

valentineu0 commented May 26, 2024

Bug Type

Function

Bugged Function

module.exports = [
    {
        name: "rr",
        $if: "old",
        code: `
        $if[$authorID==$clientOwnerIDs]
            $updateCommands
            Hot reload successfully completed.
        $endif
        `
    }
];

Version of aoi.js

v6.7.1

Version of Node.js

v20.10.0 (LTS)

Excepted Output

Files with the old loader loader.load(bla bla bla, "./commands") can be reloaded with $updateCommands, but this does not work on the new loader client.loadCommands("path", log true/false).

image
image

Relevant log output

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Faf4a Faf4a added the Type:Bug Something causing unexpected behaviour label May 29, 2024
@Faf4a
Copy link
Member

Faf4a commented Jun 1, 2024

can't reproduce..?

@berticulousnert
Copy link
Contributor

same lol

@Faf4a Faf4a added Issue:Needs Reproduction needs reproduction and removed Type:Bug Something causing unexpected behaviour labels Jun 1, 2024
@valentineu0
Copy link
Author

Still command not updating unless bot is restarted

@USERSATOSHI
Copy link
Member

does this still happen with v6.8.0?

@valentineu0
Copy link
Author

After v6.8, a single loadCommands runs the code properly, but when two different folders are requested to be loaded, a single loadCommands takes effect.

image
image
image

The reason why the error report was opened was fixed in v6.8 (except for the part I additionally stated above).

@Faf4a Faf4a added the Type:Bug Something causing unexpected behaviour label Jun 20, 2024
@USERSATOSHI
Copy link
Member

After v6.8, a single loadCommands runs the code properly, but when two different folders are requested to be loaded, a single loadCommands takes effect.

image
image
image

The reason why the error report was opened was fixed in v6.8 (except for the part I additionally stated above).

this is intended as client.loadCommands doesn't do a single loader ,

it creates a loader , loads the cmd and closes itself

which is why if u use the second one , the first one would get override

I recommend using the old setup if u are doing multiple folder loading 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue:Needs Reproduction needs reproduction Type:Bug Something causing unexpected behaviour
Projects
None yet
Development

No branches or pull requests

5 participants