Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35730][cdc-cli] PipelineDefinitionParser add parse string method #3444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-35730][cdc-cli] PipelineDefinitionParser add parse string method #3444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/PipelineDefinitionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,10 @@ public interface PipelineDefinitionParser {
* the {@link PipelineDef}.
*/
PipelineDef parse(Path pipelineDefPath, Configuration globalPipelineConfig) throws Exception;

/**
* Parse the specified pipeline definition string, merge global configurations, then generate
* the {@link PipelineDef}.
*/
PipelineDef parse(String pipelineDefText, Configuration globalPipelineConfig) throws Exception;
}
21 changes: 15 additions & 6 deletions ...k-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,39 +75,48 @@ public class YamlPipelineDefinitionParser implements PipelineDefinitionParser {
@Override
public PipelineDef parse(Path pipelineDefPath, Configuration globalPipelineConfig)
throws Exception {
JsonNode root = mapper.readTree(pipelineDefPath.toFile());
return parse(mapper.readTree(pipelineDefPath.toFile()), globalPipelineConfig);
}

@Override
public PipelineDef parse(String pipelineDefText, Configuration globalPipelineConfig)
throws Exception {
return parse(mapper.readTree(pipelineDefText), globalPipelineConfig);
}

private PipelineDef parse(JsonNode pipelineDefJsonNode, Configuration globalPipelineConfig)
throws Exception {
// Source is required
SourceDef sourceDef =
toSourceDef(
checkNotNull(
root.get(SOURCE_KEY),
pipelineDefJsonNode.get(SOURCE_KEY),
"Missing required field \"%s\" in pipeline definition",
SOURCE_KEY));

// Sink is required
SinkDef sinkDef =
toSinkDef(
checkNotNull(
root.get(SINK_KEY),
pipelineDefJsonNode.get(SINK_KEY),
"Missing required field \"%s\" in pipeline definition",
SINK_KEY));

// Transforms are optional
List<TransformDef> transformDefs = new ArrayList<>();
Optional.ofNullable(root.get(TRANSFORM_KEY))
Optional.ofNullable(pipelineDefJsonNode.get(TRANSFORM_KEY))
.ifPresent(
node ->
node.forEach(
transform -> transformDefs.add(toTransformDef(transform))));

// Routes are optional
List<RouteDef> routeDefs = new ArrayList<>();
Optional.ofNullable(root.get(ROUTE_KEY))
Optional.ofNullable(pipelineDefJsonNode.get(ROUTE_KEY))
.ifPresent(node -> node.forEach(route -> routeDefs.add(toRouteDef(route))));

// Pipeline configs are optional
Configuration userPipelineConfig = toPipelineConfig(root.get(PIPELINE_KEY));
Configuration userPipelineConfig = toPipelineConfig(pipelineDefJsonNode.get(PIPELINE_KEY));

// Merge user config into global config
Configuration pipelineConfig = new Configuration();
Expand Down
51 changes: 51 additions & 0 deletions ...c-cli/src/test/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,57 @@ void testInvalidTimeZone() throws Exception {
+ "Or use 'UTC' without time zone and daylight saving time.");
}

@Test
void testParsingFullDefinitionFromString() throws Exception {
String pipelineDefText =
"source:\n"
+ " type: mysql\n"
+ " name: source-database\n"
+ " host: localhost\n"
+ " port: 3306\n"
+ " username: admin\n"
+ " password: pass\n"
+ " tables: adb.*, bdb.user_table_[0-9]+, [app|web]_order_.*\n"
+ " chunk-column: app_order_.*:id,web_order:product_id\n"
+ " capture-new-tables: true\n"
+ "\n"
+ "sink:\n"
+ " type: kafka\n"
+ " name: sink-queue\n"
+ " bootstrap-servers: localhost:9092\n"
+ " auto-create-table: true\n"
+ "\n"
+ "route:\n"
+ " - source-table: mydb.default.app_order_.*\n"
+ " sink-table: odsdb.default.app_order\n"
+ " description: sync all sharding tables to one\n"
+ " - source-table: mydb.default.web_order\n"
+ " sink-table: odsdb.default.ods_web_order\n"
+ " description: sync table to with given prefix ods_\n"
+ "\n"
+ "transform:\n"
+ " - source-table: mydb.app_order_.*\n"
+ " projection: id, order_id, TO_UPPER(product_name)\n"
+ " filter: id > 10 AND order_id > 100\n"
+ " primary-keys: id\n"
+ " partition-keys: product_name\n"
+ " table-options: comment=app order\n"
+ " description: project fields from source table\n"
+ " - source-table: mydb.web_order_.*\n"
+ " projection: CONCAT(id, order_id) as uniq_id, *\n"
+ " filter: uniq_id > 10\n"
+ " description: add new uniq_id for each row\n"
+ "\n"
+ "pipeline:\n"
+ " name: source-database-sync-pipe\n"
+ " parallelism: 4\n"
+ " schema.change.behavior: evolve\n"
+ " schema-operator.rpc-timeout: 1 h";
YamlPipelineDefinitionParser parser = new YamlPipelineDefinitionParser();
PipelineDef pipelineDef = parser.parse(pipelineDefText, new Configuration());
assertThat(pipelineDef).isEqualTo(fullDef);
}

private final PipelineDef fullDef =
new PipelineDef(
new SourceDef(
Expand Down
Loading