Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-orthogonal cells do not evaluate correctly using the batch_eval() method #279

Open
Chronum94 opened this issue May 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Chronum94
Copy link
Collaborator

Non-orthogonal cells almost certainly have a bug in their force and energy evaluations.

In the figure below, I'm plotting E/atom as a function of a given generalized coordinate. The MACE-MP-0 large model (with L2 message passing) was used for the target data. Every energy curve except the one for the hex cell is in some reasonable degree of agreement.

image

@Tetracarbonylnickel
Copy link
Contributor

After analysing your problem I could boil it down to the batch_eval() method of our calculator. If you loop over the atoms this schould not occur.

for atoms in atoms_list:
    atoms.calc = calc
    
 energies = [atoms.get_potential_energy() for atoms in atoms_list]

Does this occur in MD simulations with apax or are these trajectories that were labeled with the apax but generated with an other method?

@Tetracarbonylnickel Tetracarbonylnickel changed the title [BUG] Non-orthogonal cells do not evaluate correctly [BUG] Non-orthogonal cells do not evaluate correctly using the batch_eval() method Jun 6, 2024
@Tetracarbonylnickel Tetracarbonylnickel added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants