Consistent trace id

[BrynCooke]

Users are having trouble correlating their logs due to there being multiple IDs floating around, sampling affecting the presence or not of a trace_id.

The behaviour we would like:

1. Otel Trace ID is exposable on logs. This functionality already exists.

telemetry:
  exporters:
    logging:
      stdout:
        format:
          json:
            display_trace_id: true

2. Promote attributes from the root span to the json container as a top level attribute. This will allow users to have headers etc that have been attached to the root span be output on logs.

telemetry:
  exporters:
    logging:
      stdout:
        format:
          json:
            promote_span_attributes:
              - my.custom.attribute 

3. TraceID generated for logs even if the request is not sampled. FIxed in: fix(telemetry): always create trace id even if the trace is not sampled #5447

4. experimental_response_trace_id should use the same logic as in #3 to enable a consistent trace id to be returned to the client. Fixed in: fix(telemetry): always create trace id even if the trace is not sampled #5447

[Samjin]

Would this method also add custom attribute to custom events as well? For instance, when user does trace.info!(), would the log object include the custom attribute?

[abernix]

This issue might be fixed by @bnjjj's #5447.

Would this method also add custom attribute to custom events as well? For instance, when user does trace.info!(), would the log object include the custom attribute?

Good question! I think @bnjjj would need to answer this part.

[Samjin]

Talked to @BrynCooke that this feature would also append to custom request logs.

[BrynCooke]

I'm going to close this and split out item 2 into a new ticket as we think the rest has been solved already.
#5540

[BrynCooke]

The PRs that closed items 3 and 4 are linked in the description, but is also here: #5447