Skip to content
This repository has been archived by the owner on Oct 19, 2020. It is now read-only.

Get convertible texture ID's should be smarter and does not consider light maps #93

Open
3 tasks done
Aadjou opened this issue Oct 26, 2017 · 12 comments
Open
3 tasks done

Comments

@Aadjou
Copy link
Contributor

Aadjou commented Oct 26, 2017

When exporting a model via io3d.storage.export* this script is used to get convertible (aka. exportable) texture keys from the model:

'../utils/processing/get-convertible-texture-ids.js'

  • The script does not consider light maps, this means our export formats that support light maps do not work.
  • The script always returns all texture keys from the set (hi-res, lo-res and source) instead of the best quality texture of a set for conversion
  • It should be configurable / optional to get light map keys and to "get texture sets" vs "get best texture for further processing"
@tomas-polach
Copy link
Contributor

tomas-polach commented Nov 23, 2017

@Aadjou @bnjm is it ok if i assign this to me? started working on this 10min ago...

@bnjm
Copy link
Contributor

bnjm commented Nov 23, 2017

Fine with me :) Will be a great improvement

@bnjm bnjm removed their assignment Nov 23, 2017
@Aadjou
Copy link
Contributor Author

Aadjou commented Nov 23, 2017

Absolutely, thank you

@tomas-polach tomas-polach assigned tomas-polach and unassigned Aadjou Nov 23, 2017
@tomas-polach
Copy link
Contributor

  • added lightmaps in: bc9ed81
  • made getTextureKeys configurable to use source maps only: 58082cc

@ghost ghost assigned ghost and Aadjou Mar 9, 2018
@ghost
Copy link

ghost commented Mar 9, 2018

I'm reopening this issue as I'm currently reviewing 3d-js and unsure if this feature is finished, thanks @Aadjou

@ghost ghost reopened this Mar 9, 2018
@tomas-polach
Copy link
Contributor

@mope1 can you provide specific details why you reopened this one? (i guess you mean "3dio-js" instead of "3d-js" ?) i'm happy to help, just let me know

@ghost
Copy link

ghost commented Mar 12, 2018

Because I'm not sure this issue is resolved and want to do some testing before i close it again

I looked at the code that finds texture keys in data3d model structures and it doesn't look like it can do everything needed, so i will test

@tomas-polach
Copy link
Contributor

good point! let's add a unit test!

@tomas-polach
Copy link
Contributor

created issue for unit test: #129

@Aadjou
Copy link
Contributor Author

Aadjou commented Mar 12, 2018

we can already see in the get-convertible-textures code
that only source textures are returned
the goal is:
source > hi-res (if not dds) > preview > none

@ghost
Copy link

ghost commented Mar 13, 2018

exactly

@tomas-polach
Copy link
Contributor

thx for the precise info, very much appreciated! :)

@Aadjou Aadjou removed their assignment Apr 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants