Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed identity support for auto-restart message pump on rotated credentials background job #157

Open
stijnmoreels opened this issue Aug 30, 2022 · 0 comments
Labels
az-key-vault All issues related to Azure Key Vault background jobs enhancement New feature or request good first issue Good for newcomers
Projects
Milestone

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Aug 30, 2022

Is your feature request related to a problem? Please describe.
Currently, we only support connection string support when registering an Azure Service Bus topic subscription that receives 'new secret version created' events to restart the message pump.

Describe the solution you'd like
Add support for managed identity with the AddCloudEventBackgroundJobUsingManagedIdentity overload. Make sure to test this with our TemporaryEnvironmentVariable so that the secret values are retrieved from the environment.
Take a look at how the AddCloudEventBackgroundJobUsingManagedIdentity is tested for an example.

@stijnmoreels stijnmoreels added enhancement New feature or request az-key-vault All issues related to Azure Key Vault background jobs labels Aug 30, 2022
@stijnmoreels stijnmoreels added this to the v0.5 milestone Aug 30, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Aug 30, 2022
@stijnmoreels stijnmoreels added the good first issue Good for newcomers label Aug 30, 2022
@stijnmoreels stijnmoreels modified the milestones: v0.5, v1.1.0 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
az-key-vault All issues related to Azure Key Vault background jobs enhancement New feature or request good first issue Good for newcomers
Projects
Roadmap
  
To do
Development

No branches or pull requests

1 participant