Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if we can use the 'auto restart on rotated credentials' and 'auto invalidate cache' together #200

Open
stijnmoreels opened this issue Apr 13, 2023 · 1 comment
Labels
az-key-vault All issues related to Azure Key Vault background jobs management All issues related to management of the project specs-required All issues where the specifications are still being defined and implementation should be halted
Projects
Milestone

Comments

@stijnmoreels
Copy link
Member

Describe the bug
Because the 'auto invalidate cache' works with every secret, it will also work with the secret that is defined in the 'auto restart on rotated credentials'. Because of this, when the invalidate job is registered before the auto rotate job, it will 'steal' the Azure Key vault event.

The problem in this case, is that we want both message handlers to handle the Azure Key vault event.

To Reproduce
Steps to reproduce the behavior:
Register both 'auto invalidate cache' job and 'auto restart on rotated credentials' handler.

Expected behavior
Event gets handled twice.

Additional context
v0.4

We could investigate in adding a scope to the registered message handlers. In those cases, an incoming message will only be handled by the message handlers that were registered for a given job (message pump). This would allow us to handle the Azure Key vault event twice (in different pumps) and also handle it twice.

@stijnmoreels stijnmoreels added management All issues related to management of the project specs-required All issues where the specifications are still being defined and implementation should be halted az-key-vault All issues related to Azure Key Vault background jobs labels Apr 13, 2023
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Apr 13, 2023
@stijnmoreels stijnmoreels added this to the v0.5 milestone Apr 13, 2023
@stijnmoreels
Copy link
Member Author

Related to arcus-azure/arcus.messaging#395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
az-key-vault All issues related to Azure Key Vault background jobs management All issues related to management of the project specs-required All issues where the specifications are still being defined and implementation should be halted
Projects
Roadmap
  
To do
Development

No branches or pull requests

1 participant