Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parts to ark-groth16? #38

Open
Pratyush opened this issue Feb 3, 2023 · 2 comments
Open

Move parts to ark-groth16? #38

Pratyush opened this issue Feb 3, 2023 · 2 comments

Comments

@Pratyush
Copy link
Member

Pratyush commented Feb 3, 2023

Hey @gakonst!

With PR arkworks-rs/groth16#44, it is possible to specify the R1CSToQAP reduction directly on the Groth16 type. Would it make sense to upstream the CircomReduction to ark-groth16 so that the logic lives there?

Happy to discuss moving other parts that make sense, and also to adopt this repo in the arkworks-rs org also, if that's something you'd want.
@gakonst
Copy link
Collaborator

gakonst commented Feb 3, 2023 •
edited
Loading

Oh yes, that would be awesome. Let's do it, happy to integrate as many parts of ark-circom in the core ecosystem as would make sense. A little stretched on time personally, but happy to review code if anyone takes up the task.

@Pratyush
Copy link
Member Author

Pratyush commented Feb 3, 2023

Awesome, maybe a good starting point would be the CircomReduction move; do you want to make a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pratyush @gakonst and others