Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "share this page" button #137

Open
nfee006 opened this issue May 12, 2021 · 3 comments
Open

Implement the "share this page" button #137

nfee006 opened this issue May 12, 2021 · 3 comments
Assignees
Labels
Comms Feeback enhancement New feature or request

Comments

@nfee006
Copy link
Member

nfee006 commented May 12, 2021

Earlier attempts have been unsuccessful, likely due to interactions between the JS libraries used by wet-boew and by dash (see open-data/ckanext-canada#1191).

image

@nfee006
Copy link
Member Author

nfee006 commented Jul 27, 2021

  1. Add the «share this page » button for the two micro applications. NF note: I had done this but it hadn’t worked right. It needs to be added here: 86551e3. https://wet-boew.github.io/v4.0-ci/docs/ref/share/share-en.html

FYI @coleweusthem. Let me know if it's going to be an issue please.

@coleweusthem
Copy link
Contributor

coleweusthem commented Jul 27, 2021

@nfee006, yeah it's not working correctly for me either. It's populating the button but for some reason clicking it does nothing. It's not throwing any errors. I think either you're right and it's a conflict (Although I would expect to see some console errors), or there's a bug in wet-boew, or for some reason, it needs to be run on canada.ca. I'm not sure there's much I can do without so an indication of why it's not working. I'll leave this for last and take another look at it then, see if I can't figure it out

@emilinecsa emilinecsa self-assigned this Apr 6, 2023
@emilinecsa
Copy link
Contributor

This button works on CSA' web page. I will talk to communications and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comms Feeback enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants