From a5383bd89bfda7c01fc25db7e1ef0cbb7ebd4454 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Tue, 6 Feb 2024 13:35:31 -0800 Subject: [PATCH] chore: remove Go (#93) We don't have any Go sources in rules_rollup so there's no reason we should install a Go toolchain or worry about upgrading it. 'aspect configure' provides the auto-generation for bzl_library targets so we don't need Gazelle either. --- BUILD.bazel | 11 ----------- CONTRIBUTING.md | 2 +- WORKSPACE | 12 ------------ internal_deps.bzl | 18 ------------------ 4 files changed, 1 insertion(+), 42 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index 227d1ff..260e22f 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -1,20 +1,9 @@ -load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary") load("@bazel_skylib//:bzl_library.bzl", "bzl_library") load("@buildifier_prebuilt//:rules.bzl", "buildifier") load("@npm//:defs.bzl", "npm_link_all_packages") npm_link_all_packages(name = "node_modules") -gazelle_binary( - name = "gazelle_bin", - languages = ["@bazel_skylib_gazelle_plugin//bzl"], -) - -gazelle( - name = "gazelle", - gazelle = "gazelle_bin", -) - buildifier( name = "buildifier.check", exclude_patterns = [ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b074f81..db2eda3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ Otherwise later tooling on CI may yell at you about formatting/linting violation Some targets are generated from sources. Currently this is just the `bzl_library` targets. -Run `bazel run //:gazelle` to keep them up-to-date. +Run `aspect configure` to keep them up-to-date. ## Using this as a development dependency of other rules diff --git a/WORKSPACE b/WORKSPACE index b6893da..d37a673 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -44,18 +44,6 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() -load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies") - -############################################ -# Gazelle, for generating bzl_library targets -load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") - -go_rules_dependencies() - -go_register_toolchains(version = "1.19.3") - -gazelle_dependencies() - # Buildifier load("@buildifier_prebuilt//:deps.bzl", "buildifier_prebuilt_deps") diff --git a/internal_deps.bzl b/internal_deps.bzl index 677c4f3..08632b7 100644 --- a/internal_deps.bzl +++ b/internal_deps.bzl @@ -9,24 +9,6 @@ load("//rollup/private:maybe.bzl", http_archive = "maybe_http_archive") def rules_rollup_internal_deps(): "Fetch deps needed for local development" - http_archive( - name = "io_bazel_rules_go", - sha256 = "099a9fb96a376ccbbb7d291ed4ecbdfd42f6bc822ab77ae6f1b5cb9e914e94fa", - urls = ["https://github.com/bazelbuild/rules_go/releases/download/v0.35.0/rules_go-v0.35.0.zip"], - ) - - http_archive( - name = "bazel_gazelle", - sha256 = "448e37e0dbf61d6fa8f00aaa12d191745e14f07c31cabfa731f0c8e8a4f41b97", - urls = ["https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.28.0/bazel-gazelle-v0.28.0.tar.gz"], - ) - - http_archive( - name = "bazel_skylib_gazelle_plugin", - sha256 = "0a466b61f331585f06ecdbbf2480b9edf70e067a53f261e0596acd573a7d2dc3", - urls = ["https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-gazelle-plugin-1.4.1.tar.gz"], - ) - http_archive( name = "io_bazel_stardoc", sha256 = "3fd8fec4ddec3c670bd810904e2e33170bedfe12f90adf943508184be458c8bb",