Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't use rules_rollup: @@aspect_bazel_lib//lib:coreutils_toolchain_type was requested byt only types [] are configured #89

Closed
peak-taekwondo opened this issue Jan 10, 2024 · 6 comments · Fixed by archen/rules_rollup#1
Labels
bug Something isn't working untriaged Requires traige

Comments

@peak-taekwondo
Copy link

peak-taekwondo commented Jan 10, 2024

What happened?

I'm trying to use rollup from Aspect in my build (I can't use esbuild because I'm doing lit-element development using decorators and that isn't supported by esbuild), but I get an error when I bazel build it saying:

Error: In _rollup rule //typescript/lit:bundle, toolchain type @@aspect_bazel_lib//lib:coreutils_toolchain_type was requested but only types [] are configured

Version

Development (host) and target OS/architectures: Ubuntu linux 22.04.2 LTS/11th Gen Intel® Core™ i7-1195G7 @ 2.90GHz × 8

Output of bazel --version: bazel 7.0.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
bazel_lib: 2.2.0
rules_js: 1.35.0
rules_ts: 2.1.0
rules_rollup: 1.0.0

Language(s) and/or frameworks involved:
TypeScript, LitElement

How to reproduce

No response

Any other information?

No response

@peak-taekwondo peak-taekwondo added the bug Something isn't working label Jan 10, 2024
@github-actions github-actions bot added the untriaged Requires traige label Jan 10, 2024
@peak-taekwondo peak-taekwondo changed the title [Bug]: [Bug]: Can't use rules_rollup: @@aspect_bazel_lib//lib:coreutils_toolchain_type was requested byt only types [] are configured Jan 10, 2024
@peak-taekwondo
Copy link
Author

Any guidance here would be greatly appreciated. I can't seem to use webpack either, and as I stated in my original bug, esbuild is insufficient due to its inability to handle decorators which are a key part of making LitElement work in a reasonable way.

@archen
Copy link
Contributor

archen commented Jan 25, 2024

@peak-taekwondo
my PRs are above, if you want to work around the issue pre-approval you're welcome to try from my commit

git_override(
    module_name = "aspect_rules_rollup",
    remote = "https://github.com/archen/rules_rollup",
    commit = "d8d982c1894c0a994203a71a357b4e710bdd94d4",
)

@bejaneps
Copy link

Facing same issue, could someone merge above pr please ?

I'm going to use @archen 's override

@alexeagle
Copy link
Member

@bejaneps thanks for the ping, it's merged now. I'll cut a release.

@pward123
Copy link

@alexeagle Running into this issue still. Can we cut a release?

@pward123
Copy link

ack, never mind. I saw latest release was 1.0.0 on the main github page, but going into releases shows the 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants