Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document impact parameter mapping #110

Open
Tracked by #159
fjebaker opened this issue May 1, 2023 · 1 comment
Open
Tracked by #159

Document impact parameter mapping #110

fjebaker opened this issue May 1, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@fjebaker
Copy link
Member

fjebaker commented May 1, 2023

Update the getting started guide and docstrings to reflect the definition of impact parameters

$$ \alpha := \frac{ p_{(\phi)} }{ p_{(t)} }, \quad \beta := \frac{ p_{(\theta)} }{ p_{(t)} } $$

and how they are mapped from an (stationary) LNRF.

@fjebaker fjebaker added the documentation Improvements or additions to documentation label May 1, 2023
@fjebaker
Copy link
Member Author

fjebaker commented Jul 4, 2023

Included here should be a demonstration of the issues in comparing first order method trajectories with second order method, especially when the observer is close to the central singularity. The error in disc size then goes as $\sim r_\text{disc} / r_\text{obs}$

@fjebaker fjebaker mentioned this issue Sep 6, 2023
13 tasks
@fjebaker fjebaker added this to the 0.5.0 milestone Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant