Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer functions: specify number of gstar knots #175

Open
fjebaker opened this issue Sep 16, 2023 · 0 comments
Open

Transfer functions: specify number of gstar knots #175

fjebaker opened this issue Sep 16, 2023 · 0 comments

Comments

@fjebaker
Copy link
Member

It would be better to get the transfer functions to sample evenly in $g^\ast$ instead of in $\theta$.

The proposed algorithm change is

  • estimate gmin gmax coarsely.
  • for $g^\ast$ in set of target $g^\ast$, root find for radius, then root find over $\theta$ for the corresponding $g^\ast$.

An issue that might crop up here are those transfer functions where the inferred extrema are worse than the area extrema. In these cases we normally see an error of 1e-4 or so, but that could still be quite damaging to the calculation. Perhaps, however, we can spend more time in the extrema optimizer at the trade off of needing fewer $g^\ast$ than theta to sample the transfer functions fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant