Skip to content

Commit

Permalink
qemu: clean up duplicate parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
@astro
astro committed Jun 17, 2023
1 parent 4c5362a commit 484e6e2
Show file tree
Hide file tree
Showing 2 changed files with 256 additions and 7 deletions.
11 changes: 4 additions & 7 deletions lib/runners/qemu.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,15 @@ in {
# qemu just hangs after shutdown, allow to exit by rebooting
"-no-reboot"

"-kernel" "${kernel}/bzImage"
"-kernel" "${kernelPath}"
"-initrd" bootDisk.passthru.initrd
"-append" "console=ttyS0 edd=off reboot=t panic=-1 ${toString microvmConfig.kernelParams}"
# hvc1 precedes hvc0 so that nixos starts serial-agetty@ on both
# without further config
"-append" "earlyprintk=ttyS0 console=ttyS0 reboot=t panic=-1 ${toString microvmConfig.kernelParams}"

"-chardev" "stdio,id=stdio,signal=off"
"-serial" "chardev:stdio"
"-device" "virtio-rng-${devType}"
"-kernel" "${kernelPath}"
"-initrd" bootDisk.passthru.initrd
# hvc1 precedes hvc0 so that nixos starts serial-agetty@ on both
# without further config
"-append" "console=hvc0 earlyprintk=ttyS0 console=ttyS0 reboot=t panic=-1 ${toString microvmConfig.kernelParams}"
] ++
lib.optionals (system == "x86_64-linux") [
"-cpu" "host,+x2apic"
Expand Down
252 changes: 252 additions & 0 deletions lib/runners/stratovirt.nix
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,252 @@
{ pkgs
, microvmConfig
, kernel
, macvtapFds
}:

let
inherit (pkgs) lib system;

inherit (microvmConfig) hostName vcpu mem balloonMem user interfaces shares socket forwardPorts devices graphics storeOnDisk bootDisk storeDisk;
# inherit (microvmConfig.qemu) extraArgs bios;

inherit (import ../. { nixpkgs-lib = pkgs.lib; }) withDriveLetters;
volumes = withDriveLetters microvmConfig;

arch = builtins.head (builtins.split "-" system);
# PCI required by vfio-pci for PCI passthrough
pciInDevices = lib.any ({ bus, ... }: bus == "pci") devices;
requirePci = shares != [] || pciInDevices;
machine = {
x86_64-linux =
if requirePci
then "q35,accel=kvm:tcg,mem-merge=on,sata=off"
else "microvm,accel=kvm:tcg,x-option-roms=off,pit=off,pic=off,rtc=off,mem-merge=on";
aarch64-linux = "virt,gic-version=max,accel=kvm:tcg";
}.${system};
devType = if requirePci
then "pci"
else "device";
kernelPath = {
x86_64-linux = "${kernel.dev}/vmlinux";
aarch64-linux = "${kernel.out}/${pkgs.stdenv.hostPlatform.linux-kernel.target}";
}.${system};

enumerate = n: xs:
if xs == []
then []
else [
(builtins.head xs // { index = n; })
] ++ (enumerate (n + 1) (builtins.tail xs));

canSandbox =
# Don't let qemu sandbox itself if it is going to call qemu-bridge-helper
! lib.any ({ type, ... }:
type == "bridge"
) microvmConfig.interfaces;

forwardPortsOptions =
let
forwardingOptions = lib.flip lib.concatMapStrings forwardPorts
({ proto, from, host, guest }:
if from == "host"
then "hostfwd=${proto}:${host.address}:${toString host.port}-" +
"${guest.address}:${toString guest.port},"
else "guestfwd=${proto}:${guest.address}:${toString guest.port}-" +
"cmd:${pkgs.netcat}/bin/nc ${host.address} ${toString host.port},"
);
in
[ forwardingOptions ];

writeQmp = data: ''
echo '${builtins.toJSON data}'
'';
in {
hypervisor = "stratovirt";

command = lib.escapeShellArgs (
[
"${pkgs.stratovirt}/bin/stratovirt"
"-name" hostName
"-M" machine
"-m" (toString (mem + balloonMem))
"-smp" (toString vcpu)
"-enable-kvm"
"-nodefaults" "-no-user-config"
# qemu just hangs after shutdown, allow to exit by rebooting
"-no-reboot"

"-kernel" "${kernel}/bzImage"
"-initrd" bootDisk.passthru.initrd
"-append" "console=ttyS0 edd=off reboot=t panic=-1 ${toString microvmConfig.kernelParams}"

"-chardev" "stdio,id=stdio,signal=off"
"-serial" "chardev:stdio"
"-device" "virtio-rng-${devType}"
"-kernel" "${kernelPath}"
"-initrd" bootDisk.passthru.initrd
# hvc1 precedes hvc0 so that nixos starts serial-agetty@ on both
# without further config
"-append" "console=hvc0 earlyprintk=ttyS0 console=ttyS0 reboot=t panic=-1 ${toString microvmConfig.kernelParams}"
] ++
lib.optionals (system == "x86_64-linux") [
"-cpu" "host,+x2apic"
"-device" "i8042"
] ++ lib.optionals bios.enable [
"-bios" "${bios.path}"
] ++
lib.optionals (system == "aarch64-linux") [
"-cpu" "host"
] ++
lib.optionals storeOnDisk [
"-drive" "id=store,format=raw,read-only=on,file=${storeDisk},if=none,aio=io_uring"
"-device" "virtio-blk-${devType},drive=store${lib.optionalString (devType == "pci") ",disable-legacy=on"}"
] ++
(if graphics.enable
then [
"-display" "gtk,gl=on"
"-device" "virtio-vga-gl"
"-device" "qemu-xhci"
"-device" "usb-tablet"
"-device" "usb-kbd"
]
else [
"-nographic"
]) ++
lib.optionals canSandbox [
"-sandbox" "on"
] ++
lib.optionals (user != null) [ "-user" user ] ++
lib.optionals (socket != null) [ "-qmp" "unix:${socket},server,nowait" ] ++
lib.optionals (balloonMem > 0) [ "-device" "virtio-balloon" ] ++
builtins.concatMap ({ image, letter, ... }:
[ "-drive" "id=vd${letter},format=raw,file=${image},if=none,aio=io_uring,discard=unmap" "-device" "virtio-blk-${devType},drive=vd${letter}" ]
) volumes ++
lib.optionals (shares != []) (
[
"-object" "memory-backend-memfd,id=mem,size=${toString (mem + balloonMem)}M,share=on"
"-numa" "node,memdev=mem"
] ++
builtins.concatMap ({ proto, index, socket, source, tag, ... }: {
"virtiofs" = [
"-chardev" "socket,id=fs${toString index},path=${socket}"
"-device" "vhost-user-fs-${devType},chardev=fs${toString index},tag=${tag}"
];
"9p" = [
"-fsdev" "local,id=fs${toString index},path=${source},security_model=none"
"-device" "virtio-9p-${devType},fsdev=fs${toString index},mount_tag=${tag}"
];
}.${proto}) (enumerate 0 shares)
)
++
lib.warnIf (
forwardPorts != [] &&
! builtins.any ({ type, ... }: type == "user") interfaces
) "${hostName}: forwardPortsOptions only running with user network" (
builtins.concatMap ({ type, id, mac, bridge, ... }: [
"-netdev" (
lib.concatStringsSep "," (
[
(if type == "macvtap" then "tap" else "${type}")
"id=${id}"
]
++ lib.optionals (type == "user" && forwardPortsOptions != []) forwardPortsOptions
++ lib.optionals (type == "bridge") [
"br=${bridge}" "helper=/run/wrappers/bin/qemu-bridge-helper"
]
++ lib.optionals (type == "tap") [
"ifname=${id}"
"script=no" "downscript=no"
]
++ lib.optionals (type == "macvtap") [
"fd=${toString macvtapFds.${id}}"
]
)
)
"-device" "virtio-net-${devType},netdev=${id},mac=${mac}"
]) interfaces
)
++
lib.optionals (lib.any ({ bus, ... }:
bus == "usb"
) devices) [
"-usb"
"-device" "usb-ehci"
]
++
builtins.concatMap ({ bus, path, ... }: {
pci = [
"-device" "vfio-pci,host=${path},multifunction=on"
];
usb = [
"-device" "usb-host,${path}"
];
}.${bus}) devices
++
extraArgs
);

canShutdown = socket != null;

shutdownCommand =
if socket != null
then
''
(
${writeQmp { execute = "qmp_capabilities"; }}
${writeQmp {
execute = "input-send-event";
arguments.events = [ {
type = "key";
data = {
down = true;
key = {
type = "qcode";
data = "ctrl";
};
};
} {
type = "key";
data = {
down = true;
key = {
type = "qcode";
data = "alt";
};
};
} {
type = "key";
data = {
down = true;
key = {
type = "qcode";
data = "delete";
};
};
} ];
}}
# wait for exit
cat
) | \
${pkgs.socat}/bin/socat STDIO UNIX:${socket},shut-none
''
else throw "Cannot shutdown without socket";

setBalloonScript =
if socket != null
then ''
VALUE=$(( $SIZE * 1024 * 1024 ))
SIZE=$( (
${writeQmp { execute = "qmp_capabilities"; }}
${writeQmp { execute = "balloon"; arguments.value = 987; }}
) | sed -e s/987/$VALUE/ | \
${pkgs.socat}/bin/socat STDIO UNIX:${socket},shut-none | \
tail -n 1 | \
${pkgs.jq}/bin/jq -r .data.actual \
)
echo $(( $SIZE / 1024 / 1024 ))
''
else null;

requiresMacvtapAsFds = true;
}

0 comments on commit 484e6e2

Please sign in to comment.