Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Standardize Labels (name:value pair) & Replica to align with other charts #326

Open
renmak opened this issue Apr 4, 2017 · 2 comments
Open

Comments

@renmak
Copy link
Contributor

renmak commented Apr 4, 2017

Is this a bug report or feature request? (choose one): Mixed; depends on perspective

Kubernetes Version (output of kubectl version): N/A

Helm Client and Tiller Versions (output of helm version): N/A

Development or Deployment Environment?: N/A

Release Tag or Master:

Expected Behavior:
As a developer and operator, it would be desirable to have standardized value.yaml in all charts.

Nova and Neutron are considered as a sample standard helm chart.

In following charts, Labels needs to be separated (just like replicas) to achieve parity with Nova & Neutron
Cinder, Ceph, Glance, Heat

What Actually Happened: This is what we have today in Cinder value.yaml

replicas:
  api: 1
  volume: 1
  scheduler: 1

labels:
  node_selector_key: openstack-control-plane
  node_selector_value: enabled

How to Reproduce the Issue (as minimally as possible):

Any Additional Comments: @v1k0d3n @alanmeadows

@renmak
Copy link
Contributor Author

renmak commented Apr 4, 2017

Created this new issue to track pending standardizing work.

Following are previous issues related to this issue
#267
#207

@wilkers-steve
Copy link
Contributor

@renmak Thanks for tracking your work and thinking about services outside of what you've tackled in nova. In regards to standardizing our charts, I think nova and neutron were the only two that needed special consideration. That need arose out of both services having some components that run on the control plane and some components that run on the compute nodes.

I don't think we should define a label for each component in the rest of the services as they'll all run in the control plane. I'd like @alanmeadows feedback on this, but I think nova and neutron should be the only two that needed attention.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants