Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeCredentials causes an error if transports is not indicated #37

Open
gianluca-venturini opened this issue Jul 12, 2022 · 0 comments

Comments

@gianluca-venturini
Copy link

gianluca-venturini commented Jul 12, 2022

Description

In the Debugger view it's not possible to set one element in excludeCredentials without indicating transports. According to the specs, transports should be optional. When I try to not add transports I see this error

TypeError: Failed to execute 'create' on 'CredentialsContainer': Failed to read the 'publicKey' property from 'CredentialCreationOptions': Failed to read the 'excludeCredentials' property from 'PublicKeyCredentialCreationOptions': The provided value is not of type 'PublicKeyCredentialDescriptor'.

while indicating one of the three transports methods everything works as expected.

Reproduction

  • Open Debugger view
  • Register a new device (e.g. Macbook Touch ID)
  • Copy the rawId to a file (in binary format)
  • Add one excludeCredentials element and upload binary file
  • Try to register a second device
  • Observe the failure
  • Expected behavior: I can register a second device

Screen Shot 2022-07-12 at 4 48 50 PM

Environment

  • Version of this library used:
  • Used web version of the tool deployed at https://webauthn.me/debugger, latest commit on master is 77679df
  • Chrome Version 103.0.5060.53 (Official Build) (arm64)
@gianluca-venturini gianluca-venturini changed the title excludeCredentials requires to indicate transports excludeCredentials causes an error if transports is not indicated Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant